[SYCL][FPGA] Change address space for USM pointers as kernel args #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query for address space of USM pointer before adding the appropriate pointer argument of OpenCL kernel. If this address space is global_device or global_host - leave it as is. Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Thank you @MrSidims! This is very useful. It will allow USM pointers that are declared outside the kernel - using |
mlychkov
previously approved these changes
Jul 13, 2020
|
Change looks ok to me but I am not familiar with USM functionality. @premanandrao are you familiar with this? If not, do you know who can review this since Mariya is on vacation? Is it @jbrodman? |
elizabethandrews
previously approved these changes
Jul 13, 2020
bader
reviewed
Jul 13, 2020
Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
dismissed stale reviews from premanandrao, elizabethandrews, jbrodman, and mlychkov
via
6df3b5b
elizabethandrews
approved these changes
Jul 13, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
Should be more cautious with inline namespaces Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@668a97d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query for address space of USM pointer before adding the appropriate
pointer argument of OpenCL kernel. If this address space is
global_device or global_host - leave it as is.
Signed-off-by: Dmitry Sidorov [email protected]