Skip to content

[SYCL][CUDA] Map/unmap pinned host memory #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 14, 2020

Conversation

steffenlarsen
Copy link
Contributor

This PRs changes map on pinned host memory to return a pointer to the pinned memory rather than copy to new memory. Likewise, unmap of pinned memory does no write operation.

Signed-off-by: Steffen Larsen [email protected]

@steffenlarsen steffenlarsen requested a review from a team as a code owner July 13, 2020 08:58
@bader bader added the cuda CUDA back-end label Jul 13, 2020
Steffen Larsen added 2 commits July 13, 2020 13:52
Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please add a test?

steffenlarsen and others added 3 commits July 13, 2020 14:28
Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner July 13, 2020 14:51
Signed-off-by: Steffen Larsen <[email protected]>
@bader bader requested a review from romanovvlad July 13, 2020 15:05
@bader bader merged commit 396759d into intel:sycl Jul 14, 2020
jsji pushed a commit that referenced this pull request Aug 11, 2023
…2098)

This commit changes "Source Lang Literal" flag from simple a scalar value
to a vector of pairs: (compile unit, source language).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@eb051c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants