[SYCL] Enable USM address spaces generation under opt flag #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
requested review from
rolandschulz,
Pennycook,
jbrodman and
mohammadfawaz
MrSidims
changed the title
AGindinson
reviewed
Jul 16, 2020
Pennycook
previously approved these changes
Jul 16, 2020
MrSidims
force-pushed
the
private/MrSidims/EnableUSMOpt
branch
from
f05e6b4 to
4b379c3
Compare
mohammadfawaz
previously approved these changes
Jul 16, 2020
rbegam
reviewed
Jul 16, 2020
This patch serves two purposes: 1. It reverts shift of accessors to global buffers from __global to __global_device address space, which was considered as not a good idea until proven otherwise. Still this shift is enabled under -fsycl_enable_usm_address_spaces option for testing; 2. It fixes a mangling issue of functions that accepts arguments of multi_ptr<> type for non-SPIR targets (see: intel#2039) Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
force-pushed
the
private/MrSidims/EnableUSMOpt
branch
from
4b379c3 to
97b255e
Compare
AGindinson
reviewed
Jul 17, 2020
mohammadfawaz
approved these changes
Jul 17, 2020
AGindinson
approved these changes
Jul 17, 2020
Pennycook
approved these changes
Jul 17, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 21, 2023
This is a bulk conversion done using the migration script. There are more transcoding tests to be converted; however they will need manual fixups, so leave them out of this bulk conversion. Original commit: KhronosGroup/SPIRV-LLVM-Translator@76fcc39
jsji
pushed a commit
that referenced
this pull request
Aug 31, 2023
This is a bulk conversion done using the migration script. There are more transcoding tests to be converted; however they will need manual fixups, so leave them out of this bulk conversion. Original commit: KhronosGroup/SPIRV-LLVM-Translator@76fcc39
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch serves two purposes:
__global_device address space, which was considered as not a good
idea until proven otherwise. Still this shift is enabled under
-fsycl_enable_usm_address_spaces option for testing;
of multi_ptr<> type for non-SPIR targets (see:
[SYCL] Mangling issues for device_ptr/global_ptr for non-SPIR targets #2039)
Plans for the future:
-fsycl_enable_usm_address_spaces option is a temporary option and
will be removed. To solve the mangling issue ENABLE_USM_ADDR_SPACE
macro will be added anyway under a combination of -fintelfpga and -Xs
flags. Future of accessor pointer at this point is unclear.
Signed-off-by: Dmitry Sidorov [email protected]