[SYCL][PTX][CUDA] Fixes debug info cloning for implicit global offset #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Larsen <[email protected]>
|
@steffenlarsen, can add a small regression test for this change? |
Signed-off-by: Steffen Larsen <[email protected]>
bader
approved these changes
Jul 16, 2020
againull
approved these changes
Jul 17, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 21, 2023
jsji
pushed a commit
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit global offset pass does not clone the debug information when cloning functions. This is fixed by inserting the new function before cloning so the parents of the clone and the original are the same, allowing the following call to
CloneFunctionIntoto also clone the debug information.