[SYCL][ESIMD] Don't add align attributes on sret arguments. #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding align attributes leads to very inefficient code generation. Author: Denis Bakhvalov <[email protected]> Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Please add a test |
I tried to but still no success. @DenisBakhvalov, can you help with test case? vadd_2d does not seem to have this problem anymore. |
I checked it as well. This workaround may not be needed anymore. |
|
The problem is not reproducible anymore - closing. |
jsji
pushed a commit
that referenced
this pull request
Aug 31, 2023
Add basic LLVM-to-SPIR-V support for the SPV_EXT_image_raw10_raw12 extension, enabling the extension if constants from the extension are found in the LLVM IR. The extension adds 2 new return values for `OpImageQueryFormat`, which are integer constants that may appear anywhere in LLVM IR. Distinguishing between the extension's constants and arbitrary constants that happen to have the same value as the extension's constants is not possible in general. Hence this patch only covers some common use cases, where the result of `OpImageQueryFormat` is directly used in an integer comparison or switch instruction. Original commit: KhronosGroup/SPIRV-LLVM-Translator@8564fd4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding align attributes leads to very inefficient code generation.
Author: Denis Bakhvalov [email protected]
Signed-off-by: Konstantin S Bobrovsky [email protected]