[SYCL] Fix handling of queue::in_order property #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed one of the sycl::queue constructor was ignoring the queue::in_order property. Also did some refactoring so now queue_impl checks properties to undrestand if in-order queue is required rather than relying on flag which is passed to constructor.
bader
reviewed
Jul 20, 2020
v-klochkov
reviewed
Jul 20, 2020
| @@ -84,7 +79,11 @@ class queue_impl { | |||
| "as the context does not contain the given device.", | |||
| PI_INVALID_DEVICE); | |||
| if (!MHostQueue) { | |||
| MCommandQueue = createQueue(Order); | |||
| const QueueOrder qorder = | |||
There was a problem hiding this comment.
Tiny comment: qorder -> QOrder or QO (please start var names with a capital letter)
v-klochkov
approved these changes
Jul 20, 2020
jsji
pushed a commit
that referenced
this pull request
Sep 7, 2023
Specification: KhronosGroup/SPIRV-Registry#216 Original commit: KhronosGroup/SPIRV-LLVM-Translator@387841b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed one of the sycl::queue constructor was ignoring the
queue::in_order property.
Also did some refactoring so now queue_impl checks properties to
undrestand if in-order queue is required rather than relying on
flag which is passed to constructor.