[SYCL] Improve UX for abi_check.py tool #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2020 12:49
The tool now prints a header with a correct LIT run line. Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
romanovvlad
reviewed
Jul 20, 2020
| @@ -3784,6 +3789,10 @@ _ZN2cl4sycl6kernelC1EP10_cl_kernelRKNS0_7contextE | |||
| _ZN2cl4sycl6kernelC1ESt10shared_ptrINS0_6detail11kernel_implEE | |||
| _ZN2cl4sycl6kernelC2EP10_cl_kernelRKNS0_7contextE | |||
| _ZN2cl4sycl6kernelC2ESt10shared_ptrINS0_6detail11kernel_implEE | |||
| _ZN2cl4sycl6level010make_queueERKNS0_7contextEm | |||
There was a problem hiding this comment.
Probably we should sort symbols to make it easier to understand what symbols were changed between releases.
There was a problem hiding this comment.
The script sorts symbols:
Line 53 in 13a1e49
Developers, however, not necessarily use it. This is why I also updated header to discourage people from editing these files manually.
jsji
pushed a commit
that referenced
this pull request
Aug 31, 2023
Requiring the `Shader` capability for any module that uses `llvm.bitreverse` is problematic for OpenCL execution environments. Only require the `Shader` capability if we cannot use the `BitInstructions` capability. Fixes KhronosGroup/SPIRV-LLVM-Translator#2139 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8701279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool now prints a header with a correct LIT run line.