Skip to content

[SYCL] Minor host task corrections #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

KarachunIvan
Copy link
Contributor

  1. Fixed compilation error which appeared in case of usage
    get_native_mem method with accessor with host target.
  2. Exceptions which raised in host task reported as async exceptions.

Signed-off-by: Ivan Karachun [email protected]

@KarachunIvan KarachunIvan requested a review from a team as a code owner July 20, 2020 14:21
@vladimirlaz
Copy link
Contributor

@KarachunIvan, please fix regression

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Only one minor comment.
Waiting for failures fixed.

vladimirlaz
vladimirlaz previously approved these changes Jul 21, 2020
@bader bader requested a review from s-kanaev July 21, 2020 10:33
1. Fixed compilation error which appeared in case of usage
get_native_mem method with accessor with host target.
2. Exceptions which raised in host task reported as async exceptions.
3. Fixed stable deadlock which appeared when reporting an async
exception raised in a host task.

Signed-off-by: Ivan Karachun <[email protected]>
@KarachunIvan
Copy link
Contributor Author

Had to force-push a commit because of updated commit message.

@bader
Copy link
Contributor

bader commented Jul 22, 2020

Had to force-push a commit because of updated commit message.

You can use PR title and description for that.

@KarachunIvan KarachunIvan requested a review from romanovvlad July 22, 2020 15:24
Signed-off-by: Ivan Karachun <[email protected]>
@bader bader merged commit 280b93c into intel:sycl Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants