Skip to content

Bump minimum required cmake version to 3.14. #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Bump minimum required cmake version to 3.14. #2154

merged 1 commit into from
Jul 22, 2020

Conversation

kbobrovs
Copy link
Contributor

llvm/lib/SYCLLowerIR/CMakeLists.txt uses FetchContent_MakeAvailable introduced
in cmake 3.14

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs kbobrovs requested a review from bader as a code owner July 21, 2020 17:06
@kbobrovs kbobrovs mentioned this pull request Jul 21, 2020
Closed
bader
bader reviewed Jul 21, 2020
View reviewed changes
llvm/CMakeLists.txt Outdated
Comment on lines 5 to 9
if ("${CMAKE_VERSION}" VERSION_LESS "3.14")
message(FATAL_ERROR
"Your CMake version is ${CMAKE_VERSION}. The minimum version of CMake "
"required to build LLVM is now 3.13.4.")
"required to build LLVM is now 3.14")
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be dead code now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand the comment - please elaborate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, reverted changes in the dead code.

@bader bader linked an issue Jul 21, 2020 that may be closed by this pull request
Project requires a cmake version higher than requested #2086
Closed
@kbobrovs
Bump minimum required cmake version to 3.14.
1339c89 
llvm/lib/SYCLLowerIR/CMakeLists.txt uses FetchContent_MakeAvailable introduced
in cmake 3.14

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@bader bader merged commit 5606109 into intel:sycl Jul 22, 2020
@alexbatashev
Copy link
Contributor

@bader @kbobrovs I guess I'm late to the party, but can we put the following snippet somewhere and revert this patch?

if(${CMAKE_VERSION} VERSION_LESS 3.14)
    macro(FetchContent_MakeAvailable NAME)
        FetchContent_GetProperties(${NAME})
        if(NOT ${NAME}_POPULATED)
            FetchContent_Populate(${NAME})
            add_subdirectory(${${NAME}_SOURCE_DIR} ${${NAME}_BINARY_DIR})
        endif()
    endmacro()
endif()

@kbobrovs kbobrovs deleted the sycl branch July 30, 2020 12:29
jsji pushed a commit that referenced this pull request Sep 14, 2023
@asudarsa @jsji
Fix check for (neg) zero for fpclass emulation (#2154)
9ba5c58 
We should compare not only to zero integer, but also 'negated' zero.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@1c154ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project requires a cmake version higher than requested
3 participants
@kbobrovs @alexbatashev @bader