Skip to content

[SYCL][WIP-DO-NOT-MERGE] Update namespaces of oneAPI and Intel extensions #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

[SYCL][WIP-DO-NOT-MERGE] Update namespaces of oneAPI and Intel extensions #2155

wants to merge 16 commits into from

Conversation

jbrodman
Copy link
Contributor

This PR makes the following changes to extensions in DPC++:

  1. Extensions are now in the namespace sycl::ext
  2. General language extensions are in sycl::ext::oneapi
  3. Intel HW specific extensions are in sycl::ext::intel

@jbrodman
Copy link
Contributor Author

/summary:run

jbrodman added 4 commits July 21, 2020 17:08
@jbrodman
clang-format
2444fed 
Signed-off-by: James Brodman <[email protected]>
@jbrodman
more clang-format
5e5305a 
Signed-off-by: James Brodman <[email protected]>
@jbrodman
Merge branch 'sycl' into namespacechange
2f9b0c2 
Signed-off-by: James Brodman <[email protected]>
@jbrodman
Resolve paths after merge
a32fea1 
Signed-off-by: James Brodman <[email protected]>
@MrSidims MrSidims requested a review from GarveyJoe July 23, 2020 07:58
@MrSidims
Copy link
Contributor

I'm fine with updating namespaces in general and for FPGA in particular, but would like to hear from @GarveyJoe

kbobrovs
kbobrovs reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving spec constant implementation from experimental to ext::oneapi is premature. Those APIs are known to get deprecated with SYCL 2020 and replaced with new ones.

@jbrodman
Update tests.
5c111f4 
Signed-off-by: James Brodman <[email protected]>
@GarveyJoe
Copy link
Contributor

I'm fine with updating namespaces in general and for FPGA in particular, but would like to hear from @GarveyJoe

I think this will break most of our existing tests and code samples. Can you stagger the change? I.e. initially include the functions in both namespaces to give us time to convert our code and then after a grace period remove support for the old namespace?

@jbrodman jbrodman mentioned this pull request Jul 31, 2020
Merged
@jbrodman jbrodman closed this Aug 3, 2020
jsji pushed a commit that referenced this pull request Sep 21, 2023
@svenvh @sys-ce-bb
Convert remaining transcoding tests to opaque pointers (#2155)
569c4e5 
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@9bd7ced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbobrovs kbobrovs kbobrovs left review comments

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@MrSidims MrSidims Awaiting requested review from MrSidims

@Pennycook Pennycook Awaiting requested review from Pennycook

@v-klochkov v-klochkov Awaiting requested review from v-klochkov

@GarveyJoe GarveyJoe Awaiting requested review from GarveyJoe

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@Fznamznon Fznamznon Awaiting requested review from Fznamznon

@premanandrao premanandrao Awaiting requested review from premanandrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrodman @MrSidims @GarveyJoe @kbobrovs