[SYCL] Fix undefined behaviour during graph cleanup #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the switch to using the command member field to mark nodes as visited during graph traversal, deleting nodes during the traversal leads to invalid memory access whenever there's a node with multiple indirect dependencies on another node. This patch fixes the issue by moving the deletion of the nodes to take place post-traversal.
This approach shows better performance with floating point reduction which is cleanup-intensive. Signed-off-by: Sergey Semenov <[email protected]>
sergey-semenov
force-pushed
the
cleanupfix
branch
from
85890f6 to
42a5a35
Compare
|
Sorry for the force push, ended up accidentally pushing the wrong patch the first time |
Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
romanovvlad
approved these changes
Jul 24, 2020
|
Unrelated test failure, to be temporarily disabled in #2173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to using the command member field to mark nodes as
visited during graph traversal, deleting nodes during the traversal
leads to invalid memory access whenever there's a node with multiple
indirect dependencies on another node. This patch fixes the issue by
moving the deletion of the nodes to take place post-traversal.