Skip to content

[SYCL][NFC] Move stream_impl.hpp to source dir #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 26, 2020

Conversation

romanovvlad
Copy link
Contributor

No description provided.

@romanovvlad romanovvlad requested review from againull and a team as code owners July 23, 2020 22:43
romanovvlad and others added 8 commits July 24, 2020 02:00
With the switch to using the command member field to mark nodes as
visited during graph traversal, deleting nodes during the traversal
leads to invalid memory access whenever there's a node with multiple
indirect dependencies on another node. This patch fixes the issue by
moving the deletion of the nodes to take place post-traversal.
This approach shows better performance with floating point reduction
which is cleanup-intensive.

Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

@bader
Copy link
Contributor

bader commented Jul 25, 2020

@romanovvlad, please, take care of buildbot failure.

@bader bader merged commit f4f7b83 into intel:sycl Jul 26, 2020
@romanovvlad romanovvlad deleted the private/vromanov/MoveStreamImpl branch July 27, 2020 07:12
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
[CTS] extend tests for urEnqueueEventsWait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants