Skip to content

[SYCL] Fix copyback bug for container based buffers. #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

cperkinsintel
Copy link
Contributor

The C++17 buffers from contiguous containers have a small bug where they don't copy back all the data correctly. This fixes this and adds a test.

@cperkinsintel cperkinsintel requested a review from a team as a code owner July 24, 2020 01:28
@cperkinsintel cperkinsintel changed the title Container buffer copies back [SYCL] fix copyback bug for container based buffers. Jul 24, 2020
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, even thought one test failed.

All buffer constructors in the failed test 'interop-task.cpp' accept 1 arg of size_t type, thus the fails seems unrelated to this patch.

@bader bader changed the title [SYCL] fix copyback bug for container based buffers. [SYCL] Fix copyback bug for container based buffers. Jul 24, 2020
@romanovvlad
Copy link
Contributor

Disabling the failed test #2173

@bader bader merged commit da6d1dc into intel:sycl Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants