[SYCL] Fix the dummy implementation of piProgramLink in the L0 plugin #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only case supported so far is linking a single compiled program, add a non-assertion check for other cases. The program returned by piProgramLink is supposed to be a new program: since the dummy implementation returns the same one, add a retain for it. Signed-off-by: Sergey Semenov <[email protected]>
|
"Retain" was one of the options we discussed earlier, but agreed we'd just fail. See #1871 |
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[NATIVECPU] Report success for urProgramCompile and urProgramLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only case supported so far is linking a single compiled program, add
a non-assertion check for other cases. The program returned by
piProgramLink is supposed to be a new program: since the dummy
implementation returns the same one, add a retain for it.
Signed-off-by: Sergey Semenov [email protected]