Skip to content

[SYCL][Driver] Fix issue that sycl is not able to print internal defi… #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 3, 2020
Merged

[SYCL][Driver] Fix issue that sycl is not able to print internal defi… #2188

merged 7 commits into from
Aug 3, 2020

Conversation

haonanya
Copy link
Contributor

clang++ -fsycl -dM -E -x c++ /dev/null is not able to print internal defines, the patch aims to fix this issue. It will emit the output to terminal as well as produce the bundled .ii file.
Signed-off-by: haonanya [email protected]

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it looks like you have some tests that need addressing that are using preprocessing options.

haonanya1 and others added 4 commits July 31, 2020 16:43
@haonanya
Copy link
Contributor Author

haonanya commented Aug 2, 2020

@mdtoguchi . Modified the patch and all pre-check-in pass already.
Thanks very much.

mdtoguchi
mdtoguchi previously approved these changes Aug 2, 2020
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@bader bader merged commit fa8953d into intel:sycl Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants