[SYCL] Check return of Expected<T> when reading section size content #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community pull down introduced Expected<T> on the return of getContents. Apply the needed check after return to satisfy. From the llvm manual: All Error instances, whether success or failure, must be either checked or moved from (via std::move or a return) before they are destructed Signed-off-by: Michael D Toguchi <[email protected]>
bader
approved these changes
Jun 14, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Jun 28, 2021
Bring spirv.hpp in sync with f95c3b3 ("Merge pull request intel#219 from
cmarcelo/SPV_EXT_shader_atomic_float16_add", 2021-06-23) from
github.com/KhronosGroup/SPIRV-Headers .
Notably, this brings the SPV_KHR_integer_dot_product extension enum
values and CPP_for_OpenCL source language enum value, together with
other additions. There are some reorderings too.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@6847551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community pull down introduced Expected on the return of getContents. Apply
the needed check after return to satisfy.
From the llvm manual: All Error instances, whether success or failure, must be
either checked or moved from (via std::move or a return) before they are
destructed
Signed-off-by: Michael D Toguchi [email protected]