[SYCL] Add implementation of sycl::intel::barrier #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes barrier as a free function, aligned with group_barrier from SYCL 2020 provisional. Naming is aligned with the existing DPC++ group algorithms, hence barrier in place of group_barrier. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
enhancement
Closer alignment with 2020 provisional. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Pennycook
requested review from
AlexeySachkov,
jbrodman,
mkinsner and
a team
as code owners
|
Please fix test/build failures. |
I don't think they're related to this PR. The same test is failing across multiple PRs. |
Even better! |
v-klochkov
previously approved these changes
Jul 29, 2020
sycl/doc/extensions/GroupAlgorithms/SYCL_INTEL_group_algorithms.asciidoc
Outdated
Show resolved
Hide resolved
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Fix L0 build issues for testing. Signed-off-by: John Pennycook <[email protected]>
If scope is too narrow, implementation will ignore it. Signed-off-by: John Pennycook <[email protected]>
|
@mkinsner: Hi Mike, this PR requires your approval. |
jbrodman
approved these changes
Jul 31, 2020
@v-klochkov: I think @jbrodman's review counts here. |
v-klochkov
approved these changes
Aug 4, 2020
vladimirlaz
added a commit
that referenced
this pull request
Aug 5, 2020
This reverts commit 3df81ac.
This was referenced Aug 5, 2020
bader
pushed a commit
that referenced
this pull request
Aug 5, 2020
…2261) This reverts commit 3df81ac. SYCL::barrier.cpp is failing for every run after merging the PR both on Windows and Linux (e.g. http://ci.llvm.intel.com:8010/#/builders/18/builds/3851)
jsji
pushed a commit
that referenced
this pull request
Nov 16, 2023
A set of llvm.vector.reduce.* intrinsics doesn't have straight forward operation equivalent on the SPIRV side. The easiest solution to this problem is to use scalar operation on each pair of vector elements and repeat until there is only one value. Original commit: KhronosGroup/SPIRV-LLVM-Translator@fe088cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes barrier as a free function, aligned with group_barrier from SYCL 2020
provisional.
Naming is aligned with the existing DPC++ group algorithms, hence barrier in
place of group_barrier.
Signed-off-by: John Pennycook [email protected]