-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][NFC] Small refactoring #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Small refactoring #2204
Conversation
romanovvlad
commented
Jul 29, 2020
- Use C++ cast instead of C casts
- Move implemenetation of several handler methods to source dir
1. Use C++ cast instead of C casts 2. Move implemenetation of several handler methods to source dir
Looks good, but accessor.cpp LIT test reported a fail and it is known as a stable test. |
It's not old one accessor from basic_tests, this one from atomic_ref and has been added quite recently. |
atomic_ref/accessor should start passing after recent update of L0. |
[NFC] Remove "dependencies" on tests