Skip to content

[SYCL][NFC] Small refactoring #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romanovvlad
Copy link
Contributor

  1. Use C++ cast instead of C casts
  2. Move implemenetation of several handler methods to source dir

1. Use C++ cast instead of C casts
2. Move implemenetation of several handler methods to source dir
@romanovvlad romanovvlad requested a review from a team as a code owner July 29, 2020 12:29
@romanovvlad romanovvlad requested a review from v-klochkov July 29, 2020 12:29
@v-klochkov
Copy link
Contributor

Looks good, but accessor.cpp LIT test reported a fail and it is known as a stable test.

@romanovvlad
Copy link
Contributor Author

Looks good, but accessor.cpp LIT test reported a fail and it is known as a stable test.

It's not old one accessor from basic_tests, this one from atomic_ref and has been added quite recently.
I have seen this fail in another PR, so it's not related to the change.
Trying to root cause the fail, but it turns to be difficult one.

@romanovvlad
Copy link
Contributor Author

Looks good, but accessor.cpp LIT test reported a fail and it is known as a stable test.

It's not old one accessor from basic_tests, this one from atomic_ref and has been added quite recently.
I have seen this fail in another PR, so it's not related to the change.
Trying to root cause the fail, but it turns to be difficult one.

atomic_ref/accessor should start passing after recent update of L0.

@romanovvlad romanovvlad merged commit 8c13580 into intel:sycl Aug 4, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
[NFC] Remove "dependencies" on tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants