[SYCL] Fix opencl/sycl interoperability #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nawrinsu
force-pushed
the
opencl_interop_constructor
branch
from
4092fba to
543ffc4
Compare
|
@nawrinsu Please, add a test for this case. |
nawrinsu
force-pushed
the
opencl_interop_constructor
branch
6 times, most recently
from
3e2f1b0 to
4f92e76
Compare
romanovvlad
requested changes
Aug 3, 2020
Currently SYCL object creation from OpenCL object fails with segmentation fault because of invalid GlobalPlugin. This patch fixes opencl/sycl interop constructor by initializing GlobalPlugin before using it. Signed-off-by: Nawrin Sultana <[email protected]>
nawrinsu
force-pushed
the
opencl_interop_constructor
branch
from
4f92e76 to
a2ec408
Compare
|
@nawrinsu please don't use force-push as it doesn't allow to track changes and makes us do the full review again. |
s-kanaev
reviewed
Aug 4, 2020
romanovvlad
approved these changes
Aug 6, 2020
jsji
pushed a commit
that referenced
this pull request
Nov 30, 2023
- change Scope argument to one of two available options: ScopeWorkgroup/ScopeWorkgroup - fix arguments order in calls to OpCooperativeMatrixLoadKHR() Original commit: KhronosGroup/SPIRV-LLVM-Translator@4e1d3e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SYCL object creation from OpenCL object fails with
segmentation fault because of invalid GlobalPlugin. This patch fixes opencl/sycl
interop constructor by initializing GlobalPlugin before using it.
Signed-off-by: Nawrin Sultana [email protected]