[WIP][SYCL] update event profiling support with the new APIs. #2251
Conversation
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
|
tag @jandres742 |
| Event->ZeEvent, ZE_EVENT_TIMESTAMP_CONTEXT_START, &ContextStart)); | ||
| ContextStart *= ZeTimerResolution; | ||
| return ReturnValue(uint64_t{ContextStart}); | ||
| ze_kernel_timestamp_result_t* tsResult = nullptr; |
There was a problem hiding this comment.
why is this not allocated memory?
| &ContextEnd)); | ||
| ContextEnd *= ZeTimerResolution; | ||
| return ReturnValue(uint64_t{ContextEnd}); | ||
| ze_kernel_timestamp_result_t* tsResult = nullptr; |
There was a problem hiding this comment.
this should be allocated, and different from the "start" memory, right?
| ContextStart *= ZeTimerResolution; | ||
| return ReturnValue(uint64_t{ContextStart}); | ||
| ze_kernel_timestamp_result_t* tsResult = nullptr; | ||
| ZE_CALL(zeCommandListAppendQueryKernelTimestamps( |
There was a problem hiding this comment.
Appends a query of an events’ timestamp value(s) into a command list.
I don't see how this is going to achieve what's needed. It looks like these timestamp query should be appended around the command being profiled. Could you explain how this is working?
| ContextStart *= ZeTimerResolution; | ||
| return ReturnValue(uint64_t{ContextStart}); | ||
| ze_kernel_timestamp_result_t* tsResult = nullptr; | ||
| ZE_CALL(zeCommandListAppendQueryKernelTimestamps( |
There was a problem hiding this comment.
We are requesting here in the host for the timestamp after execution has completed. We need to use zeEventQueryKernelTimestamp
|
@rbegam, ping. |
|
taking a look. it needs some following up. |
|
the support has been included, closing this as a duplicate. |
|
Duplicate of 6d34b95. |
* add support for the 'fcmp false' instruction * fcmp false: present vector of false values as ConstantNull Original commit: KhronosGroup/SPIRV-LLVM-Translator@aeeaf6c
Signed-off-by: rbegam [email protected]