Skip to content

[NFC][SYCL] Stabilize sub_group LIT tests #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Conversation

vladimirlaz
Copy link
Contributor

  • Fixed OCL_ICD_FILENAMES capturing to LIT environment.
  • Disable sub_group tests which fail on some ISAs on OpenCL CPU.
  • Change local and global workgroup sizes to make them dividend
    of all possible sub_group sizes. That will fix test failures
    in the last sub_group of local group.
  • Remove use of deprecated shuffle methods.
  • Fixed tests where sub_group local ID exceed sub_group size.

 - Fixed OCL_ICD_FILENAMES capturing to LIT environment.
 - Disable sub_group tests which fail on some ISAs on OpenCL CPU.
 - Change local and global workgroup sizes to make them dividend
   of all possible sub_group sizes. That will fix test failures
   in the last sub_group of local group.
 - Remove use of deprecated shuffle methods.
 - Fixed tests where sub_group local ID exceed sub_group size.
@vladimirlaz vladimirlaz requested a review from a team as a code owner August 4, 2020 15:30
@vladimirlaz vladimirlaz changed the title [WIP][NFC][SYCL] Stabilize sub_group LIT tests [NFC][SYCL] Stabilize sub_group LIT tests Aug 4, 2020
@Pennycook
Copy link
Contributor

Change local and global workgroup sizes to make them dividend of all possible sub_group sizes. That will fix test failures in the last sub_group of local group.

Isn't it important to test that the final sub-group in each work-group still supports these operations? The final sub-group will require some special handling (because in some cases the results of certain shuffles are undefined) but I don't think we should only test evenly divisible cases.

@vladimirlaz
Copy link
Contributor Author

Change local and global workgroup sizes to make them dividend of all possible sub_group sizes. That will fix test failures in the last sub_group of local group.

Isn't it important to test that the final sub-group in each work-group still supports these operations? The final sub-group will require some special handling (because in some cases the results of certain shuffles are undefined) but I don't think we should only test evenly divisible cases.

In fact it means that we are testing test itself and OpenCL RT because the difference between divisible and non-divisible case is in OpenCL RT and test but not in SYCL RT.

So I removed this case

@Pennycook
Copy link
Contributor

In fact it means that we are testing test itself and OpenCL RT because the difference between divisible and non-divisible case is in OpenCL RT and test but not in SYCL RT.

So I removed this case

I'm not sure I understand. Are you saying that because the SYCL compiler just forwards these functions to __spirv built-ins and doesn't give special handling to uneven divisions, we shouldn't have tests in the SYCL compiler? Instead, testing that the SPIR-V instructions do the correct thing should be handled by OpenCL tests?

@vladimirlaz
Copy link
Contributor Author

e correct thing should be handled by

Yes, you are right. This is what I was trying to say.

Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM

@Pennycook
Copy link
Contributor

This is what I was trying to say.

Ok, got it. Thanks for the explanation.

@bader bader merged commit f9e8ffc into intel:sycl Aug 5, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
add low-power events experimental extension spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants