Skip to content

[NFC][SYCL] Enable LIT for FPGA on Windows #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2020
Merged

[NFC][SYCL] Enable LIT for FPGA on Windows #2262

merged 3 commits into from
Sep 2, 2020

Conversation

vladimirlaz
Copy link
Contributor

The tests are enabled back as there were uplift of OpenCL RT for Intel FPGA emulator.

@vladimirlaz vladimirlaz requested a review from a team as a code owner August 5, 2020 06:42
sergey-semenov
sergey-semenov previously approved these changes Aug 5, 2020
View reviewed changes
@vladimirlaz vladimirlaz changed the title [NFC][SYCL] Enable LIT for FPGA on Windows [WIP][NFC][SYCL] Enable LIT for FPGA on Windows Aug 5, 2020
@vladimirlaz
Copy link
Contributor Author

The submission is blocked by the bug in OpenCL FPGA RT on Windows which causes sporadic crashes with the following backtrace. Waiting for the fix before submission.

0x000000A18D9F55D0  0x00007FFFBA98FA75 task_executor64_emu!RegisterGlobalAtExitNotification+0x10625
0x000000A18D9F5600  0x00007FFFBA987F4B task_executor64_emu!RegisterGlobalAtExitNotification+0x8afb
0x000000A18D9F5720  0x00007FFFBA986450 task_executor64_emu!RegisterGlobalAtExitNotification+0x7000
0x000000A18D9F5780  0x00007FFFBA9869E8 task_executor64_emu!RegisterGlobalAtExitNotification+0x7598
0x000000A18D9F57D0  0x00007FFFBA984559 task_executor64_emu!RegisterGlobalAtExitNotification+0x5109
0x000000A18D9F5800  0x00007FFFF81D477F ntdll!_chkstk+0x11f
0x000000A18D9F5F30  0x00007FFFF8134BEF ntdll!RtlWalkFrameChain+0x14bf
0x000000A18D9F66D0  0x00007FFFF81D34EE ntdll!KiUserExceptionDispatcher+0x2e
0x000000A18D9F67B0  0x00007FFFF4CC9129 KERNELBASE!RaiseException+0x69
0x000000A18D9F6820  0x00007FFFC9AD486D VCRUNTIME140!CxxThrowException+0xad
0x000000A18D9F6870  0x00007FFFBB4042F0 tbb!tbb::detail::r1::acquire_writer+0x11676
0x000000A18D9F68B0  0x00007FFFBA9626C8 task_executor64_emu+0x26c8
0x000000A18D9F68E0  0x00007FFFBA962D12 task_executor64_emu+0x2d12
0x000000A18D9F6920  0x00007FFFBA9620B7 task_executor64_emu+0x20b7
0x000000A18D9F6980  0x00007FFFBA965CD5 task_executor64_emu+0x5cd5
0x000000A18D9F69B0  0x00007FFFBA963014 task_executor64_emu+0x3014
0x000000A18D9F69F0  0x00007FFFBA962387 task_executor64_emu+0x2387
0x000000A18D9F6A20  0x00007FFFBA966008 task_executor64_emu+0x6008
0x000000A18D9F6A50  0x00007FFFBA9672ED task_executor64_emu+0x72ed
0x000000A18D9F6B50  0x00007FFFBB3F7D08 tbb!tbb::detail::r1::acquire_writer+0x508e
0x000000A18D9F6BB0  0x00007FFFBB4007EF tbb!tbb::detail::r1::acquire_writer+0xdb75
0x000000A18D9F6BE0  0x00007FFFBB40EA3E tbb!tbb::detail::r1::acquire_writer+0x1bdc4
0x000000A18D9F6C20  0x00007FFFBB4137D3 tbb!tbb::detail::r1::acquire_writer+0x20b59
0x000000A18D9FFC60  0x00007FFFBB413AAB tbb!tbb::detail::r1::acquire_writer+0x20e31
0x000000A18D9FFC90  0x00007FFFF4B91FFA ucrtbase!o_exp+0x5a
0x000000A18D9FFCC0  0x00007FFFF57D7974 KERNEL32!BaseThreadInitThunk+0x14
0x000000A18D9FFD40  0x00007FFFF819A271 ntdll!RtlUserThreadStart+0x21

@vladimirlaz vladimirlaz requested a review from bader as a code owner August 19, 2020 05:57
bader
bader requested changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pre-commit failures.

@vladimirlaz vladimirlaz deleted the win_fpga_lit branch August 31, 2020 18:39
@vladimirlaz vladimirlaz restored the win_fpga_lit branch September 2, 2020 11:23
@vladimirlaz vladimirlaz reopened this Sep 2, 2020
@vladimirlaz vladimirlaz changed the title [WIP][NFC][SYCL] Enable LIT for FPGA on Windows [NFC][SYCL] Enable LIT for FPGA on Windows Sep 2, 2020
@vladimirlaz vladimirlaz requested review from bader, sergey-semenov and romanovvlad and removed request for sergey-semenov September 2, 2020 14:29
@romanovvlad romanovvlad merged commit 58eea55 into intel:sycl Sep 2, 2020
@vladimirlaz vladimirlaz deleted the win_fpga_lit branch April 23, 2021 06:27
jsji pushed a commit that referenced this pull request Dec 21, 2023
@bwlodarcz @sys-ce-bb
Access out of scope fix in OCLToSPIRVBase::transBuiltin (#2262)
d409714 
OldRetTy pointer was passed to lambda by reference. This means that
in lambda it's real C-like type was Value ** pointing to the stack
within of the transBuiltin stack frame. Logic of lambda is executed in
doConversion function executed in destructor of BuiltinCallMutator.
The stack frame is unaccessible during the destructor call and
it worked only as undfined behaviour.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@85a10e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@romanovvlad romanovvlad romanovvlad approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladimirlaz @bader @romanovvlad @sergey-semenov