[SYCL] Translating annotations for functions #2272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of saving llvm.gloabl.annotations for functions after SPIRV translation Add test for this Signed-off-by: amochalo <[email protected]>
Making translation of annotations (UserSemantic) into a separate function Improving the test Signed-off-by: amochalo <[email protected]>
|
Could you please create review for this fix in https://github.com/KhronosGroup/SPIRV-LLVM-Translator? |
Signed-off-by: amochalo <[email protected]>
Signed-off-by: amochalo <[email protected]>
jsji
pushed a commit
that referenced
this pull request
Dec 21, 2023
Replace with the {starts,ends}_with variants, after LLVM commit
5ac1295 ("[ADT] Deprecate StringRef::{starts,ends}with (#75491)",
2023-12-17).
This is a mechanical change applied using:
git grep -l startswith | xargs sed -i -e 's/startswith/starts_with/g'
git grep -l endswith | xargs sed -i -e 's/endswith/ends_with/g'
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@adf1f52
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ec-gap Improvements to align CTS and Spec for Virtual Memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of saving llvm.global.annotations for functions after SPIRV translation
Add test for this
Signed-off-by: amochalo [email protected]