[SYCL] Fix hang in ProgramManager class #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flegontov <[email protected]>
alexanderfle
requested review from
a team and
rbegam
and removed request for
a team
s-kanaev
reviewed
Aug 7, 2020
Signed-off-by: Alexander Flegontov <[email protected]>
Signed-off-by: Alexander Flegontov <[email protected]>
dm-vodopyanov
previously approved these changes
Aug 10, 2020
Signed-off-by: Alexander Flegontov <[email protected]>
|
@kbobrovs, Could you please review this PR? |
s-kanaev
approved these changes
Aug 10, 2020
jsji
pushed a commit
that referenced
this pull request
Dec 18, 2023
Due to change in LLVM IR in commit dea16eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes sporadic hangs caused by data race in NativePrograms variable of the ProgramManager class.
The current mutex lock from the program cache is not thread-safe.
When multiple threads use their own queues then they use different contexts and then they use their own program caches.
And since multiple threads can queue own command of kernel execution in parallel,
then each thread will lock its own program cache mutex but the access into NativePrograms variable remains with a race between the threads.
Signed-off-by: Alexander Flegontov [email protected]