[SYCL]Move kernel diagnostics to the call, enable template trail on errors #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a WIP that intends to move the diagnostics for a kernel to the point in which it is called for the first time. This should give us access to the actual call location (AND provide for diagnostics up an instantiation tree) to provide bettter feedback to the user. Currently, this doesn't actually add the call location anywhere (except it moves the 'lambda' capture check to the call location, perhaps incorrectly). Additionally, this patch doesn't pass accessor-type-diagnostics for some reason, so I still need to look into that. Finally, this starts diagnosing that the kernel isn't a cxx-record-decl, since that is in violation of the spec at the moment. Also note there are a couple of TODOs I have to look into.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Note this is WIP, but I wanted to make sure @cperkinsintel , @srividya-sundaram and @Fznamznon saw it, since it is the result of a different discussion. It also changes depending on whether this goes before #2259 |
Everything should be back to how it was!
erichkeane
changed the title
erichkeane
changed the title
|
This should be ready for review now! Depending on the order of the union-fix (#2285) and @cperkinsintel 's re-submit (#2259) there will be a touch more work for the ones that come later. |
No longer necessary, since I opted to get the kernel function anyway. That said, I still think it is less awkward to use the getParamDecl function instead of a dereferenced param_begin.
premanandrao
previously approved these changes
Aug 11, 2020
|
The test failure may need a restart. Not sure. |
Fznamznon
reviewed
Aug 12, 2020
|
Thanks for the reviews! I've got another patch coming to fix the requested changes in a few minutes. |
elizabethandrews
previously approved these changes
Aug 12, 2020
bader
reviewed
Aug 12, 2020
Co-authored-by: Alexey Bader <[email protected]>
erichkeane
dismissed stale reviews from elizabethandrews and Fznamznon
via
53e3f54
elizabethandrews
approved these changes
Aug 12, 2020
Fznamznon
approved these changes
Aug 12, 2020
jsji
pushed a commit
that referenced
this pull request
Jan 11, 2024
Signed-off-by: Lu, John <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@42788c2
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
add accidentally removed numactl from the benchmark job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the diagnostics for the kernel to the point in which the
kernel is called, rather than when generating the kernel. This means that
the call location is available (so that the checkers can be taught how to print
better diagnostics in the future). The biggest impact of this, is that it
causes us to print the template instantiation 'tree' since these are diagnosing
right away.
Currently, this uses the call location to better diagnose the lambda check (see
the additional note there!), and prints a kernel-parameter-must-be-lambda-or-functor
error.