[SYCL] Avoid using intrinsics to get global id in stream #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling intrinsics to get global id when calculating the offset of the work item in the flush buffer. When stream is used in a single_task kernel this could cause an overhead on targets like FPGA. That is why use global atomic variable to calculate offsets. Signed-off-by: Artur Gainullin <[email protected]>
|
/summary:run |
s-kanaev
approved these changes
Aug 17, 2020
| // Test to check that intrinsics to get a global id are not generated for the | ||
| // stream. | ||
|
|
||
| // CHECK-NOT: call spir_func void @{{.*}}__spirvL22initGlobalInvocationId{{.*}} |
There was a problem hiding this comment.
Nit. I think you should check that there's no call to spirv initGlobalInvocationId inside the kernel. That means, that the kernel should still be there.
There was a problem hiding this comment.
I didn't get this comment. This check covers all call instructions i.e. inside the kernel as well.
There was a problem hiding this comment.
What I mean is that if the frontend doesn't generate this instruction for some reason we have to be sure that the kernel is still generated. I believe that there are proper checks for that in frontend part of tests.
jsji
pushed a commit
that referenced
this pull request
Feb 29, 2024
…eJointMatrixINTEL (#2318) This PR is to ensure that CooperativeMatrixLoadCheckedINTEL, CooperativeMatrixStoreCheckedINTEL and CooperativeMatrixConstructCheckedINTEL instructions can correctly accept TypeJointMatrixINTEL as an input during both forward and reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@632c3f626990f36
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0 v2] fix native kernel handle interop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling intrinsics to get global id when calculating the offset of
the work item in the flush buffer. When stream is used in a single_task
kernel this could cause an overhead on targets like FPGA. That is why
use global atomic variable to calcualte offsets.
Signed-off-by: Artur Gainullin [email protected]