Skip to content

[SYCL] Re-enable interop task test #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

[SYCL] Re-enable interop task test #2342

merged 1 commit into from
Aug 20, 2020

Conversation

alexbatashev
Copy link
Contributor

No description provided.

@alexbatashev alexbatashev force-pushed the reenable_interop_task branch from e9b9d9d to cef503d Compare August 20, 2020 11:48
@alexbatashev alexbatashev marked this pull request as ready for review August 20, 2020 12:49
@alexbatashev alexbatashev requested a review from a team as a code owner August 20, 2020 12:49
@alexbatashev alexbatashev requested a review from againull August 20, 2020 12:49
@alexbatashev alexbatashev changed the title [DO NOT COMMIT][SYCL] Re-enable interop task test [SYCL] Re-enable interop task test Aug 20, 2020
@bader bader merged commit 8f8d34c into intel:sycl Aug 20, 2020
@v-klochkov
Copy link
Contributor

BTW, don't we need 'const' specifier in some other places? I.e.:
https://github.com/intel/llvm/blob/sycl/sycl/test/helpers.hpp#L67
https://github.com/intel/llvm/blob/sycl/sycl/test/basic_tests/diagnostics/handler.cpp#L32
https://github.com/intel/llvm/blob/sycl/sycl/test/scheduler/BasicSchedulerTests.cpp#L33
and probably in sycl/test/basic_tests/accessor/accessor.cpp

@alexbatashev alexbatashev deleted the reenable_interop_task branch August 21, 2020 06:28
@bader bader mentioned this pull request Aug 21, 2020
Merged
alexbatashev added a commit that referenced this pull request Aug 21, 2020
@alexbatashev
Revert "[SYCL] Re-enable interop task tests (#2342)"
8c69d45 
This reverts commit 8f8d34c.
@alexbatashev alexbatashev mentioned this pull request Aug 21, 2020
Merged
bader pushed a commit that referenced this pull request Aug 21, 2020
@alexbatashev
Revert "[SYCL] Re-enable interop task tests (#2342)" (#2354)
77edc2b 
This reverts commit 8f8d34c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@againull againull Awaiting requested review from againull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbatashev @v-klochkov @bader