[NFC][SYCL] Make Visitor functions private, other than the entry points #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a cleanup task I saw that should happen. None of this is really necessary to be public, so make them all private.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Aug 19, 2020
jsji
pushed a commit
that referenced
this pull request
Mar 7, 2024
If SPV_KHR_bit_instructions is not enabled lower llvm.bitreverse.* to a function in LLVM IR. Signed-off-by: Lu, John <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@08d939609f186a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cleanup task I saw that should happen. None of this is really
necessary to be public, so make them all private.