[SYCL] Add missing constructors and propety methods #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing constructors and propety methods for context, program and sampler.
alexbatashev
previously approved these changes
Aug 25, 2020
| static_cast<pi_context_properties>(PI_CONTEXT_PROPERTIES_CUDA_PRIMARY), | ||
| static_cast<pi_context_properties>(UseCUDAPrimaryContext), 0}; | ||
|
|
||
| getPlugin().call<PiApiKind::piContextCreate>( | ||
| props, DeviceIds.size(), DeviceIds.data(), nullptr, nullptr, &MContext); | ||
| Props, DeviceIds.size(), DeviceIds.data(), nullptr, nullptr, &MContext); | ||
| #else | ||
| cl::sycl::detail::pi::die("CUDA support was not enabled at compilation time"); |
There was a problem hiding this comment.
Not related to this patch, but this message is misleading. If I saw this in my program, I would have started looking for dpcpp compiler options to enable CUDA.
alexbatashev
approved these changes
Aug 26, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Fix "use after release" issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing constructors and propety methods for context, program and sampler.