[SYCL] Enable USM indirect access for interop kernels #2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
approved these changes
Aug 27, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 29, 2024
The prototype for `getErrorMessage()` is declared in `LLVMSPIRVLib.h`, but `SPIRVError.cpp` defining that function did not include `LLVMSPIRVLib.h`. This can be problematic for builds that use `-fvisibility=hidden`. Fixes KhronosGroup/SPIRV-LLVM-Translator#2376 Original commit: KhronosGroup/SPIRV-LLVM-Translator@81f78d24db36622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #2185 was committed, USM indirect access was enabled for all kernels, both interoperability and native. This patch returns old behaviour by enabling that feature for kernels, created with interoperability constructor.