Skip to content

[SYCL] added type declarations to support boolX and pass scalar_sycl_types test #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

[SYCL] added type declarations to support boolX and pass scalar_sycl_types test #2381

merged 1 commit into from
Aug 31, 2020

Conversation

cperkinsintel
Copy link
Contributor

added type declarations to support boolX and pass scalar_sycl_types test

Signed-off-by: Chris Perkins [email protected]

turinevgeny
turinevgeny reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@turinevgeny turinevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it fix a LIT test? I'm asking to figure out if a new test is needed.

@cperkinsintel
Copy link
Contributor Author

It's for one of the SYCL conformance tests scalars_sycl_types_ws .

turinevgeny
turinevgeny approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@turinevgeny turinevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romanovvlad romanovvlad merged commit 4dfd500 into intel:sycl Aug 31, 2020
@cperkinsintel cperkinsintel deleted the cperkins-bool4-support branch August 31, 2020 16:16
jsji pushed a commit that referenced this pull request Feb 29, 2024
@MrSidims @sys-ce-bb
Fix function with unused sret parameter (#2381)
4ddf13b 
Usually sret parameters are accessed by a memory instruction, from which
would tell SPIRVTypeScavenger which type to use for this function
parameter. But if sret parameter is unused later in the module scavenger
would fail attempting to deduce type from the mangled name.

Signed-off-by: Sidorov, Dmitry <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f71747917eb56ef
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@pbalcer
Merge pull request #2381 from igchor/add_bench_mt
e690bc4 
[Benchmarks] Add MemcpyExecute scenario with high ops count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turinevgeny turinevgeny turinevgeny approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cperkinsintel @turinevgeny @romanovvlad