Skip to content

[SYCL] Uplift the dependencies (missing the TBB link) #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2020
Merged

[SYCL] Uplift the dependencies (missing the TBB link) #2388

merged 5 commits into from
Sep 2, 2020

Conversation

yanfeng3721
Copy link
Contributor

Uplift the dependency(the link of deps will be updated later)
OCLCPU 2020.10.7.0.15->2020.11.8.0.28
OCLFPGAEMU 2020.10.7.0.15->2020.11.8.0.28
OCLFPGALINUX 20200701_000002->20200811_000001
OCLFPGAWIN 20200701_000002->20200811_000006
TBB 2021.1.8.515->2021.1.9.636

@fadeeval @yanfeng3721
Specify asm test with unsupported cuda
e209129 
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: yanfeng xiao <[email protected]>
@yanfeng3721 yanfeng3721 requested a review from a team as a code owner August 29, 2020 23:59
vladimirlaz
vladimirlaz reviewed Aug 30, 2020
View reviewed changes
vladimirlaz
vladimirlaz suggested changes Aug 30, 2020
View reviewed changes
@yanfeng3721 yanfeng3721 changed the title Yanfeng3721 [SYCL]Uplift the dependency(the link of deps will be updated later) Aug 31, 2020
@yanfeng3721 yanfeng3721 force-pushed the yanfeng3721 branch 5 times, most recently from e96eb2d to 7dafd0e Compare September 1, 2020 08:10
@yanfeng3721 yanfeng3721 changed the title [SYCL]Uplift the dependency(the link of deps will be updated later) [SYCL]Uplift the dependency(missing the TBB link) Sep 1, 2020
@yanfeng3721
Copy link
Contributor Author

  1. Flag LT test stream.cpp/reduction_usm.cpp/broadcast.cpp/broadcast_fp64.cpp as XFAIL.
  2. Update OCLCPU/OCLFPGA links to binaries
  3. Missing TBB links

@yanfeng3721 yanfeng3721 force-pushed the yanfeng3721 branch 2 times, most recently from 66aca53 to 31049db Compare September 1, 2020 09:09
@yanfeng3721 yanfeng3721 requested a review from bader as a code owner September 1, 2020 09:16
bader
bader requested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve merge conflicts and fix CI regression.
Do we have version, which doesn't introduce failures to stream.cpp/reduction_usm.cpp/broadcast.cpp/broadcast_fp64.cpp tests?

@yanfeng3721
Copy link
Contributor Author

@bader , the PR is ready now except TBB link is missing. "oneTBB 2021.1-beta09 will be published next week after oneAPI 2021.1-beta09 is RTM’ed (now RTM is scheduled for ww37.2). "

@bader bader changed the title [SYCL]Uplift the dependency(missing the TBB link) [SYCL] Uplift the dependencies (missing the TBB link) Sep 2, 2020
bader
bader approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this question:

Do we have version, which doesn't introduce failures to stream.cpp/reduction_usm.cpp/broadcast.cpp/broadcast_fp64.cpp tests?

Are we going to fix these in the future?

@bader
Copy link
Contributor

bader commented Sep 2, 2020

What about this question:

Do we have version, which doesn't introduce failures to stream.cpp/reduction_usm.cpp/broadcast.cpp/broadcast_fp64.cpp tests?

Are we going to fix these in the future?

I see you answered this question already in #2388 (comment) comment.

@bader bader merged commit c7f915e into intel:sycl Sep 2, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@pbalcer
Merge pull request #2388 from igchor/suppress_test
a6f8866 
[Test] add flaky test to match file for L0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfzhu tfzhu tfzhu left review comments

@bader bader bader approved these changes

@vladimirlaz vladimirlaz vladimirlaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanfeng3721 @bader @tfzhu @vladimirlaz @fadeeval