Skip to content

[SYCL] Separate opencl specific event constructs in the lit test. #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

[SYCL] Separate opencl specific event constructs in the lit test. #2396

merged 3 commits into from
Sep 8, 2020

Conversation

rbegam
Copy link
Contributor

@rbegam rbegam commented Aug 31, 2020

Signed-off-by: rbegam [email protected]

@rbegam rbegam requested a review from a team as a code owner August 31, 2020 22:02
@rbegam rbegam requested review from v-klochkov and bader August 31, 2020 22:02
@bader
Copy link
Contributor

bader commented Sep 3, 2020

The change looks good to me, but CI failure is concerning.

@romanovvlad, @vladimirlaz, any idea about the root cause of this failure?

$ "env" "SYCL_DEVICE_TYPE=GPU" "SYCL_BE=PI_CUDA" "/localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.obj/tools/sycl/test/basic_tests/Output/event_profiling_info.cpp.tmp.out"

event_profiling_info.cpp.tmp.out: /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/sycl/test/basic_tests/event_profiling_info.cpp:37: int main(): Assertion `Submit <= Start' failed.

@romanovvlad
Copy link
Contributor

The change looks good to me, but CI failure is concerning.

@romanovvlad, @vladimirlaz, any idea about the root cause of this failure?

$ "env" "SYCL_DEVICE_TYPE=GPU" "SYCL_BE=PI_CUDA" "/localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.obj/tools/sycl/test/basic_tests/Output/event_profiling_info.cpp.tmp.out"
event_profiling_info.cpp.tmp.out: /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/sycl/test/basic_tests/event_profiling_info.cpp:37: int main(): Assertion `Submit <= Start' failed.

No ideas.

@vladimirlaz
Copy link
Contributor

the failure unrelated to the change as it affects only LIT and different test has failed.
I have no idea about the root cause. BTW: the test has been XFAILED in 6d34b95

@bader
Copy link
Contributor

bader commented Sep 4, 2020

the failure unrelated to the change as it affects only LIT and different test has failed.
I have no idea about the root cause. BTW: the test has been XFAILED in 6d34b95

The XFAIL condition there is wrong. See 6d34b95#r42033961.

vladimirlaz
vladimirlaz previously approved these changes Sep 7, 2020
View reviewed changes
bader
bader reviewed Sep 7, 2020
View reviewed changes
@bader bader requested a review from vladimirlaz September 7, 2020 19:01
@vladimirlaz vladimirlaz merged commit 4ecb504 into intel:sycl Sep 8, 2020
jsji pushed a commit that referenced this pull request Mar 26, 2024
@victor-eds @sys-ce-bb
Allow specialization constant length arrays (#2396)
4c15e0b 
SPIR-V arrays can have their length specified via a specialization
constant. In case an `alloca` instruction uses a specialization
constant `s` as length, generate an array variable of length `s`.

Signed-off-by: Victor Perez <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@9fdddf081365a1b
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@callumfare
Merge pull request #2396 from kswiecicki/init-results-fix
2651b05 
[L0] Add nullopt check before init results access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbegam @bader @romanovvlad @vladimirlaz @v-klochkov