[NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute #2399

smanna12 · 2020-09-01T02:06:15Z

Commit b2da2c8 added support for new spelling [[intel::reqd_sub_group_size()]]
and deprecated previous spelling [[cl::intel_reqd_sub_group_size()]] of the
IntelReqdSubGroupSize attribute to match with spec.

This patch removes that deprecated spelling and updates several tests
of IntelReqdSubGroupSize attribute with new spelling.

Signed-off-by: Soumi Manna [email protected]

Commit b2da2c8 added support for new spelling [[intel::reqd_sub_group_size()]] and deprecated previous spelling [[cl::intel_reqd_sub_group_size()]] of the IntelReqdSubGroupSize attribute. This patch removes that deprecated spelling and updates several tests of IntelReqdSubGroupSize attribute. Signed-off-by: Soumi Manna <[email protected]>

Signed-off-by: Soumi Manna <[email protected]>

alexbatashev

sycl/ contents LGTM

alexbatashev · 2020-09-01T07:40:48Z

sycl/test/inline-asm/asm_16_empty.cpp

+        cl::sycl::range<1>{this->getOutputBufferSize()}, [=
+    ](cl::sycl::id<1> wiID) [[intel::reqd_sub_group_size(16)]] {


clang-format does bad job on this constructs. I'd prefer it to be like this:

Suggested change

cl::sycl::range<1>{this->getOutputBufferSize()}, [=

](cl::sycl::id<1> wiID) [[intel::reqd_sub_group_size(16)]] {

// clang-format off

cl::sycl::range<1>{this->getOutputBufferSize()},

[=](cl::sycl::id<1> wiID) [[intel::reqd_sub_group_size(16)]] {

// clang-format on

If you agree, please apply to all such cases.

Yes, I agree. I will update all cases.

alexbatashev · 2020-09-01T07:41:52Z

sycl/test/inline-asm/asm_no_operands.cpp

+                              asm("barrier");
 #endif
-        });
+                            });


These changes seem to be unrelated.

Yes, this is unrelated. Clang-format complained about this. I will change this to the original.

alexbatashev · 2020-09-01T07:42:54Z

sycl/test/inline-asm/letter_example.cpp

+                                               [[intel::reqd_sub_group_size(
+                                                   16)]] {


Suggested change

[[intel::reqd_sub_group_size(

16)]] {

// clang-format off

[[intel::reqd_sub_group_size(16)]] {

// clang-format on

Same as above.

I will update this too.

alexbatashev · 2020-09-01T07:43:42Z

sycl/test/inline-asm/malloc_shared_32.cpp

+                        "rw"(&b[i] + 16), "rw"(&a[i]), "rw"(&a[i] + 16),
+                        "rw"(&c[i]), "rw"(&c[i] + 16));


These changes are also irrelevant.

Yes, this is unrelated. Clang-format complained about this. I will change this to the original.

Fznamznon

FE changes look fine

elizabethandrews

FE changes LGTM

bader · 2020-09-02T10:11:54Z

@smanna12, could you address the comments from @alexbatashev, please?

Signed-off-by: Soumi Manna <[email protected]>

premanandrao

LGTM

Signed-off-by: Soumi Manna <[email protected]>

smanna12

I have updated tests. @alexbatashev, could you please review them?

smanna12 · 2020-09-03T00:06:16Z

sycl/test/inline-asm/letter_example.cpp

+           // clang-format off
                                                 a[idx[0]]++;
+      // clang-format on
 #endif
                                               });


Clang-format makes unrelated change here. I have turned the format off.

smanna12 · 2020-09-03T01:35:45Z

sycl/test/inline-asm/malloc_shared_32.cpp

+                        // clang-format off
                            "rw"(&b[i] + 16), "rw"(&a[i]), "rw"(&a[i] + 16), "rw"(&c[i]),
                            "rw"(&c[i] + 16));
 #else


Clang-format makes unrelated change here. I have turned the format off.

elizabethandrews

FE changes LGTM

smanna12 · 2020-09-03T14:12:27Z

Thanks everyone for the review.

Disable CUDA sycl e2e tests

smanna12 added 2 commits August 31, 2020 19:03

Fix Clang-format issue

309452c

Signed-off-by: Soumi Manna <[email protected]>

smanna12 changed the title ~~[SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute~~ [Do Not Review][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute Sep 1, 2020

smanna12 added 2 commits August 31, 2020 20:14

Fix tests failures

0536be2

Signed-off-by: Soumi Manna <[email protected]>

Fix clang-format issues

8b7a71c

Signed-off-by: Soumi Manna <[email protected]>

smanna12 changed the title ~~[Do Not Review][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute~~ [Do Not Review][NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute Sep 1, 2020

smanna12 changed the title ~~[Do Not Review][NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute~~ [NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute Sep 1, 2020

smanna12 marked this pull request as ready for review September 1, 2020 05:47

smanna12 requested review from elizabethandrews, Fznamznon, premanandrao and a team as code owners September 1, 2020 05:47

smanna12 requested review from alexbatashev and AlexeySachkov September 1, 2020 05:47

alexbatashev previously approved these changes Sep 1, 2020

View reviewed changes

Fznamznon previously approved these changes Sep 1, 2020

View reviewed changes

elizabethandrews previously approved these changes Sep 1, 2020

View reviewed changes

address @alexbatashev comments

d4eba22

Signed-off-by: Soumi Manna <[email protected]>

smanna12 dismissed stale reviews from elizabethandrews, Fznamznon, and alexbatashev via d4eba22 September 2, 2020 13:32

smanna12 added 3 commits September 2, 2020 07:13

Fix Clang-format issues

d394e8e

Signed-off-by: Soumi Manna <[email protected]>

fix Clang-format issues

80bdcb0

Signed-off-by: Soumi Manna <[email protected]>

fix Clang-format issues

0ef28da

Signed-off-by: Soumi Manna <[email protected]>

premanandrao previously approved these changes Sep 2, 2020

View reviewed changes

Fix Clang-format issues

1666ac4

Signed-off-by: Soumi Manna <[email protected]>

smanna12 dismissed premanandrao’s stale review via 1666ac4 September 2, 2020 19:07

smanna12 added 2 commits September 2, 2020 15:52

Fix errors

3533b73

Signed-off-by: Soumi Manna <[email protected]>

Fix errors

641c8cf

Signed-off-by: Soumi Manna <[email protected]>

smanna12 added 2 commits September 2, 2020 16:48

make change in tests

cf23379

Signed-off-by: Soumi Manna <[email protected]>

Fix clang-format issue

c524943

Signed-off-by: Soumi Manna <[email protected]>

smanna12 commented Sep 3, 2020

View reviewed changes

smanna12 requested a review from alexbatashev September 3, 2020 00:16

smanna12 commented Sep 3, 2020

View reviewed changes

alexbatashev approved these changes Sep 3, 2020

View reviewed changes

smanna12 requested review from elizabethandrews, Fznamznon and premanandrao September 3, 2020 11:22

elizabethandrews approved these changes Sep 3, 2020

View reviewed changes

bader merged commit 9dda36f into intel:sycl Sep 3, 2020

smanna12 mentioned this pull request Oct 14, 2021

[SYCL] Adding support for 'sycl_special_class' attribute. #3892

Merged

Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025

Merge pull request #2399 from RossBrunton/ross/nocuda

545781b

Disable CUDA sycl e2e tests

		cl::sycl::range<1>{this->getOutputBufferSize()}, [=
		](cl::sycl::id<1> wiID) [[intel::reqd_sub_group_size(16)]] {

		"rw"(&b[i] + 16), "rw"(&a[i]), "rw"(&a[i] + 16),
		"rw"(&c[i]), "rw"(&c[i] + 16));

[NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute #2399

[NFC][SYCL] Remove deprecated spelling of IntelReqdSubGroupSize attribute #2399

Uh oh!

Conversation

smanna12 commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexbatashev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fznamznon left a comment

Choose a reason for hiding this comment

Uh oh!

elizabethandrews left a comment

Choose a reason for hiding this comment

Uh oh!

bader commented Sep 2, 2020

Uh oh!

premanandrao left a comment

Choose a reason for hiding this comment

Uh oh!

smanna12 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elizabethandrews left a comment

Choose a reason for hiding this comment

Uh oh!

smanna12 commented Sep 3, 2020

Uh oh!

Uh oh!

smanna12 commented Sep 1, 2020 •

edited

Loading

smanna12 left a comment •

edited

Loading