Add negative tests for inline asm #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbegam <[email protected]>
fadeeval
force-pushed
the
private/fadeeval/asm_negative_tests
branch
from
09b3fb6 to
8f7b5d2
Compare
Added new parameter to launchInlineASMTests to be able to get the exceptions out of it to check their content in negative tests. Updated spelling of `reqd_sub_group_size` attribute to avoid using deprecated variant of it.
| // RUN: %clangxx -fsycl %s -DINLINE_ASM -o %t.out | ||
| // RUN: not %t.out 2>&1 | FileCheck %s | ||
|
|
||
| // CHECK: Build succeeded |
There was a problem hiding this comment.
I wonder why do we have tests that expected to be successfully built in negative_tests directory?
If these tests require particular HW to catch device program build error, than I suggest to remove them as they are too fragile, IMHO
smaslov-intel
previously approved these changes
Sep 2, 2020
| @@ -0,0 +1,43 @@ | |||
| // UNSUPPORTED: cuda | |||
| // REQUIRES: gpu,linux | |||
| // RUN: %clangxx -fsycl %s -DINLINE_ASM -o %t.out | |||
There was a problem hiding this comment.
Why do you need this INLINE_ASM macro since you seem to always define it?
There was a problem hiding this comment.
It remained from positive tests, I will delete it.
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
fadeeval
force-pushed
the
private/fadeeval/asm_negative_tests
branch
from
9e81046 to
5afddf6
Compare
Signed-off-by: Aleksander Fadeev <[email protected]>
fadeeval
force-pushed
the
private/fadeeval/asm_negative_tests
branch
from
e2b6861 to
f4fbcb0
Compare
|
Don't merge please yet. |
Signed-off-by: Aleksander Fadeev <[email protected]>
|
I won't fix clang formatting on purpose. |
|
The PR can be merged now |
AlexeySachkov
approved these changes
Sep 3, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Add SDL hardening flags for MSVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for verification of error messages for inline assembly feature.
Signed-off-by: Aleksander Fadeev [email protected]