Skip to content

[SYCL] Re-implement warning that checks number of arguments #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

Fznamznon
Copy link
Contributor

GPU has limitation on size of kernel aguments, not number.

GPU has limitation on size of kernel aguments, not number.
@bader
Copy link
Contributor

bader commented Sep 3, 2020

I suggest we rename clang/test/SemaSYCL/num-args-overflow.cpp test.

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise, looks okay to me.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the unnecessary 'note'

@bader bader merged commit e00ab74 into intel:sycl Sep 4, 2020
jsji pushed a commit that referenced this pull request Mar 26, 2024
* Update magic value used in named sub group size extension

* Remove print

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@e8e06667df8f5f5
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
…rted-feature

[DevAsan] Report error when using unsupported extension API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants