[SYCL] Refactor -fsycl-esimd and -fsycl-int-header options #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-fsycl-int-header option initialization code moved closer to code section processing other SYCL options. -fsycl-esimd enables optimizations in SYCL mode, which is not necessary after intel@5976ff0
bader
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Sep 14, 2020
elizabethandrews
approved these changes
Sep 14, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Sep 15, 2020
* origin/sycl: [SYCL] Fixes in release notes (intel#2470) [SYCL] Refactor -fsycl-esimd and -fsycl-int-header options (intel#2466)
jsji
pushed a commit
that referenced
this pull request
Apr 4, 2024
It seems we currently allow OCL to SPIR-V translation only for OpenCL C sources. This PR tries to extend this to OpenCL C++ and C++ for OpenCL sources as well. Signed-off-by: Arvind Sudarsanam <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@80dfd864ae55636
iclsrc
pushed a commit
that referenced
this pull request
Apr 25, 2024
…)" (#2508) This reverts commit 80dfd864ae556369747074bbde8fc1d4c48547be. The commit break Translator in cases when user supplied function is named with the prefix which, after demangling, is the same as OpenCL builtin. The culprit code is placed in during SPIRWriter OCL pass in OCLToSPIRVBase::visitCallInst(CallInst &). Failing name would be for example atomic_fetch_and_sub_uint32_explicit. Original commit: KhronosGroup/SPIRV-LLVM-Translator@9e60105170110e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fsycl-int-header option initialization code moved closer to code
section processing other SYCL options.
-fsycl-esimd enables optimizations in SYCL mode, which is not necessary
after 5976ff0