[SYCL] uninvoked commands cleanup #2472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or if queue::wait() is not called Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
changed the title
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
|
Can we kill off commands without memory object dependencies right after they are enqueued with |
|
@sergey-semenov . Maybe we can do what you suggest, but doesn't that presume that there is only one call to enqueueImp ? What if the user makes makes multiple .submits to a queue? Or calls q.single_task and q.submit ? |
Signed-off-by: Chris Perkins <[email protected]>
|
Different approach in a different PR ( #2492 ) . Closing this one. |
jsji
pushed a commit
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Yilong Guo <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@6e62da7a514be99
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[L0] For 3-Channel memory, disable Copy engine Usage
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0] For 3-Channel memory, disable Copy engine Usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasing of resource from commands that may not have been invoked, or if queue::wait() is not called.
Signed-off-by: Chris Perkins [email protected]