[SYCL] Disable dead store elimination in early optimizations #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dead store elimination in early optimizations causes fail on GPU target for some cases.
againull
changed the title
keryell
suggested changes
Sep 17, 2020
I suspect "fail on GPU target" might be caused by some bugs in low-level runtime(s). I don't expect any problems on GPU target from removing dead stores. |
iclsrc
pushed a commit
that referenced
this pull request
Apr 11, 2024
…cess to a buildin variable (#2487) This PR is to fix the issue when SPIRV Translator expects now to see exactly GetElementPtrInst in an access chain for a builtin variable and crashes in lib/SPIRV/SPIRVUtil.cpp in replaceUsesOfBuiltinVar() with llvm_unreachable() call. See #2486 for the detailed description. Attached is a test case that demonstrates the problem and leads to a crash in current version(s) of SPIRV Translator. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a7051670770f471
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead store elimination in early optimizations causes fail on GPU target
for some cases.