[SYCL][ESIMD] reduce restriction on some esimd API based upon user feedback #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmc-rep, could you please add a short description with an explanation what was done and how? |
cmc-rep
force-pushed
the
cmc_rep-change2
branch
from
e00874d to
5bbc10c
Compare
More description added in the commit comment |
dm-vodopyanov
changed the title
cmc-rep
force-pushed
the
cmc_rep-change2
branch
from
5bbc10c to
8393201
Compare
Tests added |
…edback - allow 256-byte block load for slm - allow vector-length of 1/2/4/8/16/32 for gather and scatter Signed-off-by: Gang Y Chen <[email protected]>
cmc-rep
force-pushed
the
cmc_rep-change2
branch
from
8393201 to
281f0e0
Compare
kbobrovs
reviewed
Oct 13, 2020
| @@ -9,7 +9,22 @@ | |||
| using namespace sycl::INTEL::gpu; | |||
| using namespace cl::sycl; | |||
|
|
|||
| void kernel(accessor<int, 1, access::mode::read_write, access::target::global_buffer> &buf) __attribute__((sycl_device)) { | |||
| void kernel0(accessor<int, 1, access::mode::read_write, | |||
There was a problem hiding this comment.
Suggested change
| void kernel0(accessor<int, 1, access::mode::read_write, | |
| // TODO: add executable tests for gather/scatter with verification | |
| void kernel0(accessor<int, 1, access::mode::read_write, |
| @@ -18,3 +18,13 @@ void kernel() __attribute__((sycl_device)) { | |||
|
|
|||
| slm_block_store<int, 32>(0, v0); | |||
| } | |||
|
|
|||
| void kernel2() __attribute__((sycl_device)) { | |||
There was a problem hiding this comment.
Suggested change
| void kernel2() __attribute__((sycl_device)) { | |
| // TODO: add executable tests for slm load/stores with verification | |
| void kernel2() __attribute__((sycl_device)) { |
iclsrc
pushed a commit
that referenced
this pull request
Apr 25, 2024
Don't attempt to print the object itself (which results in binary noise) but print the relevant information from the SPIRVDecorate* objects. Original commit: KhronosGroup/SPIRV-LLVM-Translator@eb0d9f6b1e755fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]