[SYCL] populate PI (and direct SYCL RT to PI) #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the commit |
smaslov-intel
force-pushed
the
pi1
branch
3 times, most recently
from
1968626 to
ceef833
Compare
bader
previously approved these changes
Jul 3, 2019
| @@ -13,6 +13,7 @@ | |||
| #include <CL/sycl/context.hpp> | |||
| #include <CL/sycl/detail/aligned_allocator.hpp> | |||
| #include <CL/sycl/detail/common.hpp> | |||
| #include <CL/sycl/detail/pi.hpp> | |||
There was a problem hiding this comment.
Please, keep includes sorted.
Usually these types of issues are handled automatically by clang-format tool.
Signed-off-by: Sergey V Maslov <[email protected]>
…/device stuff. Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
bader
approved these changes
Jul 10, 2019
| #else | ||
| Queue = clCreateCommandQueue(ClContext, m_Device.get(), | ||
| CreationFlags, &Error); | ||
| // TODO: do we really need this old interface into PI and here? |
There was a problem hiding this comment.
No. This should be handled by OpenCL plugin. The plug-in should know where to lower piQueueCreate to clCreateCommandQueueWithProperties or to clCreateCommandQueue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incremental change on top of PI infrastructure being added in #222. It turns all of SYCL RT OpenCL calls into PI. For the time being PI implementation is still directly the OpenCL one (in pi_opencl.*), and the next step will be to run OpenCL through the PI.