[Driver][SYCL] Improvements to -fsycl-device-only behaviors #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
force-pushed
the
private/mdtoguchi/fsycl-device-only-updates
branch
3 times, most recently
from
fad73db to
53dc169
Compare
Make some improvements to -fsycl-device-only to better match the device compilations for regular -fsycl device compiles. - Do not force the device triple at the initial target setting, allowing for improved capabilities with user provided -target <triple> - Allow for proper C++ assumptions (source and standard)
mdtoguchi
force-pushed
the
private/mdtoguchi/fsycl-device-only-updates
branch
from
53dc169 to
692f758
Compare
AGindinson
reviewed
Oct 13, 2020
There was a problem hiding this comment.
The changes LGTM in general (but for a couple comments). This is a definite improvement, and wouldn't hurt the work needing to be done in scope of #1814
AGindinson
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some improvements to -fsycl-device-only to better match the device
compilations for regular -fsycl device compiles.
for improved capabilities with user provided -target