[SYCL][L0] Fixed SYCL_PI_TRACE printing problem #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL_PI_TRACE is used for internal debugging. It displays the PI function that is being called and its arguments. When piGetDeviceInfo() was called, the printing of the pointer used for a variable sized string was incorrect. Added a print() specialization. The nullptr print() specialization was also updated because specializations should be special. Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
keryell
reviewed
Oct 13, 2020
Signed-off-by: Gail Lyons <[email protected]>
smaslov-intel
previously approved these changes
Oct 13, 2020
Co-authored-by: smaslov-intel <[email protected]>
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…switch-redo Move urMemImageGetInfo success test from a switch to individual test
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…h-redo Move urMemImageGetInfo success test from a switch to individual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL_PI_TRACE is used for internal debugging. It displays
the PI function that is being called and its arguments.
When piGetDeviceInfo() was called, the printing of the
pointer used for a variable sized string was incorrect.
Added a print() specialization.
The nullptr print() specialization was also updated because
specializations should be special.
Signed-off-by: Gail Lyons [email protected]