[SYCL] Change in buffer management for integrated GPUs. #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rdeodhar <[email protected]>
smaslov-intel
suggested changes
Oct 14, 2020
smaslov-intel
suggested changes
Oct 15, 2020
| : (MemObj->MapHostPtr ? nullptr : MappedPtr)); | ||
|
|
||
| if (BufferUsesHostMem) { | ||
| (*Event)->HostSyncforMap = true; |
There was a problem hiding this comment.
this should not be needed
There was a problem hiding this comment.
Right, by signalling the event completion in map/unmap we don't need this flag at all.
smaslov-intel
previously approved these changes
Oct 16, 2020
|
/summary:run |
jandres742
reviewed
Oct 16, 2020
| // | ||
| // On integrated devices the buffer has been allocated in host memory. | ||
| if (Buffer->OnHost) { | ||
| // Wait on incoming events before doing the copy |
There was a problem hiding this comment.
what if the call is not blocking, BlockingMap = false? we would be making this call blocking, right?
There was a problem hiding this comment.
Yes, the map operation will do the copy immediately and then signal the output event.
smaslov-intel
approved these changes
Oct 20, 2020
iclsrc
pushed a commit
that referenced
this pull request
Jul 26, 2024
…ersion. (#2631) Align with llvm/llvm-project@5fd5b8a. Co-authored-by: Sven van Haastregt <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@a84bfcaf829995c
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…ests Enable cmd-buf local memory update CTS tests on L0
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Enable cmd-buf local memory update CTS tests on L0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change special-cases GPU devices with integrated memory. Buffers for these devices is allocated in host shared memory, improving performance of buffer data transfers.
Signed-off-by: rdeodhar [email protected]