[SYCL][RT] do not assume Linux always has aligned_alloc #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhammond
force-pushed
the
no_aligned_malloc
branch
from
da837c7 to
6fd7a1a
Compare
jeffhammond
changed the title
Older glibc lacks aligned_alloc (C11 and C++17). Dropping through to the POSIX option (posix_memalign) is necessary on such systems. The lazy way to detect if aligned_alloc is supported is: defined(_GLIBCXX_HAVE_ALIGNED_ALLOC) || defined(_LIBCPP_HAS_C11_FEATURES) This does not work for C++ libraries besides GCC and LLVM (e.g. MUSL) but unless those are explicitly supported and tested, we should not need to include them here anyways. The inclusion of stdlib.h was changed to cstdlib, as appropriate for C++ code. The conditional inclusion of cstdlib in the cpp file was removed since it was included unconditionally in the header. Signed-off-by: Jeff Hammond <[email protected]>
vladimirlaz
approved these changes
Oct 19, 2020
iclsrc
pushed a commit
that referenced
this pull request
Aug 15, 2024
Update a test after llvm-project commit 92a0654 ("[LowerMemIntrinsics] Lower llvm.memmove to wide memory accesses (#100122)", 2024-07-26). Original commit: KhronosGroup/SPIRV-LLVM-Translator@84f525abd741c30
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[NativeCPU] Handle null phEvent.
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[NativeCPU] Handle null phEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older glibc lacks aligned_alloc (C11 and C++17).
Dropping through to the POSIX option (
posix_memalign) is necessaryon such systems.
The lazy way to detect if aligned_alloc is supported is:
defined(_GLIBCXX_HAVE_ALIGNED_ALLOC) || defined(_LIBCPP_HAS_C11_FEATURES)This does not work for C++ libraries besides GCC and LLVM (e.g. MUSL)
but unless those are explicitly supported and tested, we should not
need to include them here anyways.
The inclusion of stdlib.h was changed to cstdlib, as appropriate for C++
code. The conditional inclusion of cstdlib in the cpp file was removed
since it was included unconditionally in the header.
Signed-off-by: Jeff Hammond [email protected]