[BuildBot] Reorder ARM and CUDA arg parsing #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM replaces x86 whereas CUDA appends, so the ARM part needs to come first for llvm_targets_to_build to be populated correctly. Signed-off-by: Hammond, Jeff R <[email protected]>
bader
changed the title
bader
approved these changes
Oct 20, 2020
iclsrc
pushed a commit
that referenced
this pull request
Aug 15, 2024
The spirv-tools package used by the job seems no longer available for Ubuntu 20.04. Original commit: KhronosGroup/SPIRV-LLVM-Translator@88e546a689b2679
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[L0 v2] extend USMFill implementation to support sizes which are not powers of 2
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0 v2] extend USMFill implementation to support sizes which are not powers of 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM replaces x86 whereas CUDA appends, so the ARM part needs to come first for
llvm_targets_to_buildto be populated correctly.This fixes the trivial bug I introduced when adding ARM support, which wasn't relevant until now because I didn't have an ARM+NVIDIA platform on which to test.
Signed-off-by: Hammond, Jeff R [email protected]