[SYCL] Second approach to piDeviceRelease resource leak fix. #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar dependency between the device_impl and the platform_impl, each holding a shared pointer to the other, which prevents their destruction. In this second approach, I've replaced the vector of shared pointers in the platform_impl with a vector of weak_ptr. It seems to work well. The destructors are getting called, and piDeviceRetain/Release calls are balanced. Signed-off-by: Chris Perkins <[email protected]>
s-kanaev
approved these changes
Oct 22, 2020
romanovvlad
approved these changes
Oct 23, 2020
|
/summary:run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piDeviceRelease resource leak fix - second attempt. There is a circular dependency between the device_impl and the platform_impl, each holding a shared pointer to the other, which prevents their destruction. In this second approach, I've replaced the vector of shared pointers in the platform_impl with a vector of weak_ptr. It seems to work well. The destructors are getting called, and piDeviceRetain/Release calls are balanced.
Original draft is here: #2668
Signed-off-by: Chris Perkins [email protected]