Skip to content

[SYCL] Fix linker error about undefined symbols #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions sycl/include/CL/sycl/half_type.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,6 @@ template <> struct numeric_limits<cl::sycl::half> {
static constexpr bool has_denorm_loss = false;
static constexpr bool tinyness_before = false;
static constexpr bool traps = false;
static constexpr float half_min = 6.103515625e-05f;
static constexpr float half_max = 65504.0f;
static constexpr float half_eps = 9.765625e-04f;
static constexpr int max_exponent10 = 4;
static constexpr int max_exponent = 16;
static constexpr int min_exponent10 = -4;
Expand All @@ -263,24 +260,24 @@ template <> struct numeric_limits<cl::sycl::half> {
static constexpr float_round_style round_style = round_to_nearest;

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half(min)() noexcept {
return half_min;
return 6.103515625e-05f; // half minimum value
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half(max)() noexcept {
return half_max;
return 65504.0f; // half maximum value
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half lowest() noexcept {
return -half_max;
return -65504.0f; // -1*(half maximum value)
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half epsilon() noexcept {
return half_eps;
return 9.765625e-04f; // half epsilon
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half
round_error() noexcept {
return 0.5F;
return 0.5f;
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half infinity() noexcept {
Expand All @@ -297,7 +294,7 @@ template <> struct numeric_limits<cl::sycl::half> {
}

static __SYCL_CONSTEXPR_ON_DEVICE const cl::sycl::half denorm_min() noexcept {
return 5.96046e-08F;
return 5.96046e-08f;
}
};

Expand Down