[Driver][SYCL] Remove real_path workaround for integration header #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We applied a workaround for integration header usage on Windows that corrected the directory name in case it did not match expectations of the file system (lowercase/uppercase like things). The workaround is not needed anymore as community has addressed the non-portable path warning directly for Windows.
AGindinson
reviewed
Oct 27, 2020
Clean up XFAIL (test now passes) and remove non-valid check
AGindinson
previously approved these changes
Oct 27, 2020
v-klochkov
previously approved these changes
Oct 27, 2020
v-klochkov
approved these changes
Oct 27, 2020
AGindinson
approved these changes
Oct 28, 2020
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…lures Mark OpenCL CPU known failing device more generally
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Mark OpenCL CPU known failing device more generally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We applied a workaround for integration header usage on Windows that
corrected the directory name in case it did not match expectations
of the file system (lowercase/uppercase like things). The workaround
is not needed anymore as community has addressed the non-portable
path warning directly for Windows.