[SYCL][LIT] Fix regex in select_device LIT test #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds two new special characters - ```[``` and ```]``` to select_device LIT test. An escape symbol will be added to these characters. This is because new OpenCL GPU runtime 20.42.18209 has such symbols in its device name, and regex generated by this test was w/o escape symbols for ```[``` and ```]```, which led to ```CL_DEVICE_NOT_FOUND``` error in run time.
|
LGTM |
rbegam
approved these changes
Oct 27, 2020
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[L0 v2] add missing urCommadBufferEnqueueExp function
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0 v2] add missing urCommadBufferEnqueueExp function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds two new special characters -
[and]toselect_device LIT test. An escape symbol will be added to these
characters. This is because new OpenCL GPU runtime 20.42.18209 has
such symbols in its device name, and regex generated by this test
was w/o escape symbols for
[and], which led toCL_DEVICE_NOT_FOUNDerror in run time.